[jormun]: For departure_boards, group_by_destination is activable in config #4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodflow
approved these changes
Apr 15, 2024
pbench
approved these changes
Apr 16, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For client as lyon, rennes and others, group_by_destination is False by default (retro-compatibility). When only one route is displayed even if the line is splitted in two directions, group_by_destination should be deactived. Ex: https://playground.navitia.io/play.html?request=https%3A%2F%2Fapi-cus.navitia.io%2Fv1%2Fcoverage%2Ffr-se-lyon%2Flines%2Fline%253Atcl%253AC24%2Fstop_areas%2Fstop_area%253Atcl%253ASA%253A5765%2Fstop_schedules%3Fcount%3D50%26
For client as ratp, destineo group_by_destination should be activated. At least one route par direction is displayed and hence date_times should be grouped by destination. Ex: http://playground.navitia.io/play.html?request=https%3A%2F%2Fapi-cus.navitia.io%2Fv1%2Fcoverage%2Ffr-pdl%2Fstop_points%2Fstop_point%253APDL%253AMOBIITI%253AQuay%253A82%2Flines%2Fline%253APDL%253ACAC%253ALine%253A1%253ALOC%2Fstop_schedules%3Fdata_freshness%3Dbase_schedule%26
Tests are added to verify configuration.