-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage property rules for routes #191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cdfab8
to
726f895
Compare
antoine-de
reviewed
Feb 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hop, some random thoughts on this PR.
I don't really know what you are trying to do, so feel free to disregard my comments if they are not relevant.
nberard
reviewed
Feb 11, 2019
c96f1b5
to
d94858a
Compare
TeXitoi
previously approved these changes
Feb 15, 2019
6c98285
to
7264421
Compare
TeXitoi
reviewed
Feb 18, 2019
TeXitoi
reviewed
Feb 18, 2019
TeXitoi
previously approved these changes
Feb 18, 2019
0ecf458
to
2ca6814
Compare
TeXitoi
previously approved these changes
Feb 19, 2019
2ca6814
to
367a099
Compare
nberard
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need
Ad the possibility to add or modify properties for routes.
see the fixtures if you want to know this should do
inputs
ouputs