Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage property rules for routes #191

Merged
merged 4 commits into from
Feb 20, 2019
Merged

Conversation

datanel
Copy link
Member

@datanel datanel commented Feb 6, 2019

Need

Ad the possibility to add or modify properties for routes.

Column Description
object route
object_id The id of the object in the NTFS
property_name route_name, direction_type, route_geometry, destination_id
property_old_value Value before modification of the property. If the field contains *, the rule is systematically applied. Otherwise, the change is only made if the old value matches.
property_value The value to be applied by the process (if the verification is ok)

see the fixtures if you want to know this should do

inputs

  • fixtures/apply_rules/input/routes.txt
  • fixtures/apply_rules/input/geometries.txt
  • fixtures/apply_rules/property_rules.txt

ouputs

  • fixtures/apply_rules/output/routes.txt
  • fixtures/apply_rules/output/geometries.txt

Copy link
Contributor

@antoine-de antoine-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hop, some random thoughts on this PR.

I don't really know what you are trying to do, so feel free to disregard my comments if they are not relevant.

src/apply_rules.rs Outdated Show resolved Hide resolved
src/apply_rules.rs Outdated Show resolved Hide resolved
src/apply_rules.rs Show resolved Hide resolved
src/apply_rules.rs Outdated Show resolved Hide resolved
src/apply_rules.rs Outdated Show resolved Hide resolved
@datanel datanel force-pushed the property_rules branch 2 times, most recently from c96f1b5 to d94858a Compare February 14, 2019 14:20
TeXitoi
TeXitoi previously approved these changes Feb 15, 2019
src/objects.rs Outdated Show resolved Hide resolved
TeXitoi
TeXitoi previously approved these changes Feb 18, 2019
TeXitoi
TeXitoi previously approved these changes Feb 19, 2019
@nberard nberard merged commit 0752fdc into hove-io:master Feb 20, 2019
@datanel datanel deleted the property_rules branch May 12, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants