Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ND-255 - Rename old Fare model and introduce new version of the Fare model #255

Merged
merged 6 commits into from
Jun 3, 2019

Conversation

woshilapin
Copy link
Contributor

The first commit is only a renaming of struct so to simplify the reviewing process, you might want to look at each commit individually.

src/objects.rs Outdated Show resolved Hide resolved
src/objects.rs Outdated Show resolved Hide resolved
@woshilapin woshilapin changed the base branch from master to fare-v2 May 29, 2019 12:25
@woshilapin woshilapin force-pushed the ND-255 branch 3 times, most recently from 045c510 to 9de00d3 Compare May 29, 2019 13:09
README.md Outdated Show resolved Hide resolved
src/objects.rs Outdated Show resolved Hide resolved
src/objects.rs Outdated Show resolved Hide resolved
src/objects.rs Outdated Show resolved Hide resolved
src/objects.rs Show resolved Hide resolved
src/objects.rs Outdated Show resolved Hide resolved
src/objects.rs Outdated Show resolved Hide resolved
src/objects.rs Show resolved Hide resolved
@datanel
Copy link
Member

datanel commented May 29, 2019

tests fail because of transit_model=0.5.0 which is not released yet

David Quintanel added 2 commits June 3, 2019 10:24
@woshilapin
Copy link
Contributor Author

I also added the feature fare-v2 in the build (change of .travis.yml).

@woshilapin
Copy link
Contributor Author

I removed the serde feature from the chrono crate in 6d9bc74.

@woshilapin
Copy link
Contributor Author

I change the currency_code type from CurrencyCode to a String to avoid having our public API depending on a crate we're not sure is gonna stay. However, I still use this crate iso4217 to do the validation during serialization and deserialization (see 341a1fe).

@datanel datanel merged commit 3cefb47 into hove-io:fare-v2 Jun 3, 2019
@woshilapin woshilapin deleted the ND-255 branch July 1, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants