Add unit test for currency serialization/deserialization #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datanel
reviewed
Jun 3, 2019
woshilapin
force-pushed
the
serde_currency
branch
2 times, most recently
from
6386a98
to
0574b9f
Compare
datanel
reviewed
Jun 5, 2019
src/utils.rs
Outdated
| fn test_de_invalid_currency_code() { | ||
| let result: Result<CurrencyCodeWrapper, _> = | ||
| serde_json::from_str("{\"currency_code\":\"XXX\"}"); | ||
| let err_msg = result.err().unwrap().to_string(); |
There was a problem hiding this comment.
let err_msg = result.unwrap_err();
There was a problem hiding this comment.
Indeed, I missed that one and it makes sense. Funny fact though, when I did change it, it complains because CurrencyWrapper does not implements std::fmt::Debug. The reason is because .unwrap_err() will panic with the value if the result is of type Ok(). I did the change in 62a3702.
datanel
changed the title
woshilapin
force-pushed
the
serde_currency
branch
from
62a3702
to
7dbd42b
Compare
ArnaudOggy
reviewed
Jun 6, 2019
src/utils.rs
Outdated
| #[cfg(test)] | ||
| mod tests { | ||
|
|
||
| #[cfg(feature = "fare-v2")] |
There was a problem hiding this comment.
You can remove this line now (feature) ;-)
woshilapin
force-pushed
the
serde_currency
branch
from
7dbd42b
to
47e6378
Compare
woshilapin
force-pushed
the
serde_currency
branch
from
487f3d0
to
22b59a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.