New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write fares v1 from v2 #274

Merged

datanel merged 4 commits into hove-io:master from ArnaudOggy:write-farev1-from-v2

Jul 3, 2019

Contributor

ArnaudOggy commented Jun 26, 2019

No description provided.

ArnaudOggy added do_not_merge wip labels

woshilapin reviewed

View reviewed changes

src/ntfs/write.rs Outdated Show resolved Hide resolved

src/ntfs/read.rs Outdated Show resolved Hide resolved

src/ntfs/read.rs Outdated Show resolved Hide resolved

src/ntfs/write.rs Outdated Show resolved Hide resolved

src/ntfs/write.rs Outdated Show resolved Hide resolved

src/ntfs/write.rs Outdated Show resolved Hide resolved

ArnaudOggy force-pushed the write-farev1-from-v2 branch 6 times, most recently from 7e3a0d7 to dc91c94 Compare

June 28, 2019 10:35

woshilapin reviewed

View reviewed changes

src/ntfs/write.rs Outdated Show resolved Hide resolved

woshilapin reviewed

View reviewed changes

src/ntfs/write.rs Outdated Show resolved Hide resolved

woshilapin reviewed

View reviewed changes

src/ntfs/write.rs Show resolved Hide resolved

woshilapin reviewed

View reviewed changes

src/ntfs/write.rs Show resolved Hide resolved

woshilapin reviewed

View reviewed changes

src/ntfs/write.rs Outdated Show resolved Hide resolved

ArnaudOggy force-pushed the write-farev1-from-v2 branch 9 times, most recently from 25c37c9 to efdaf6a Compare

July 2, 2019 15:40

ArnaudOggy changed the base branch from fare-v2 to master

July 2, 2019 15:46


          Write fares v1 from v2

ac8fe93

ArnaudOggy force-pushed the write-farev1-from-v2 branch from 2c50118 to ac8fe93 Compare

July 3, 2019 08:23

ArnaudOggy added need_review and removed do_not_merge wip labels

ArnaudOggy requested a review from woshilapin

July 3, 2019 08:44

ArnaudOggy requested a review from datanel

July 3, 2019 08:44

woshilapin and others added 2 commits

July 3, 2019 13:29


          Refactor of the extraction of the ticket for faresv2 to faresv1 conve…

a8fe643

…rsion


          Merge pull request #3 from woshilapin/write-farev1-from-v2

4e83469

Refactor of the extraction of the ticket for faresv2 to faresv1 conversion

woshilapin previously approved these changes

View reviewed changes

src/ntfs/write.rs Show resolved Hide resolved

datanel reviewed

View reviewed changes

src/ntfs/write.rs Outdated Show resolved Hide resolved

src/ntfs/write.rs Outdated Show resolved Hide resolved

src/ntfs/write.rs Outdated Show resolved Hide resolved

src/ntfs/write.rs Outdated Show resolved Hide resolved

src/ntfs/write.rs Outdated Show resolved Hide resolved

src/ntfs/write.rs Outdated Show resolved Hide resolved

src/ntfs/write.rs Outdated Show resolved Hide resolved

src/ntfs/write.rs Outdated Show resolved Hide resolved

src/ntfs/write.rs Outdated Show resolved Hide resolved


          Write fares v1 from v2 - Improvements

1f30e36

ArnaudOggy dismissed woshilapin’s stale review via

1f30e36

July 3, 2019 12:32

woshilapin approved these changes

View reviewed changes

datanel merged commit 70d21b9 into hove-io:master

ArnaudOggy deleted the write-farev1-from-v2 branch

July 31, 2019 08:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment