Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed binaries #316

Merged
merged 2 commits into from Aug 30, 2019
Merged

removed binaries #316

merged 2 commits into from Aug 30, 2019

Conversation

datanel
Copy link
Member

@datanel datanel commented Aug 9, 2019

Binaries are (will be) now in https://github.com/CanalTP/tartare-tools

  • remove transXchange bin when it is completely implemented
  • delete jenkins job for building docker image

README.md Show resolved Hide resolved
woshilapin
woshilapin previously approved these changes Aug 9, 2019
@woshilapin
Copy link
Contributor

woshilapin commented Aug 29, 2019

Nice job about moving around the documentation. When looking, I see that you moved all the deprecated things about fares but file renaming seems inconsistent:

  • ntfs_deprecated_fares_reading.md
  • deprecated_ntfs_fares_writing.md

Also, in the first one, you edited the content to replace fares with deprecated fares (at least in the title). Might be nice to do the same in the second file too.

Another thing, the file read_transxchange.md could be renamed into transxchange_to_ntfs_specs.md (but maybe you didn't touch this one because we're actively working on it)...

woshilapin
woshilapin previously approved these changes Aug 29, 2019
@datanel
Copy link
Member Author

datanel commented Aug 29, 2019

@woshilapin done

@woshilapin woshilapin merged commit 1c4397a into hove-io:master Aug 30, 2019
@datanel datanel deleted the move-bin branch August 30, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants