Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add a more complete test on 'gtfs2ntfs' #678

Merged
merged 2 commits into from Jul 27, 2020

Conversation

woshilapin
Copy link
Contributor

@woshilapin woshilapin commented Jul 24, 2020

Create a test fixtures GTFS including:

  • Creation of trip_property
  • Creation of equipment
  • levels
  • pathways
  • platform_code
  • frequencies
  • use of a configuration
  • use a prefix

One question remain, do we need to keep the following tests (which should now all be covered by this complete fixture):

  • test/fixtures/gtfs2ntfs/levels_and_pathways
  • tests/fixtures/gtfs2ntfs/platforms
  • tests/fixtures/gtfs2ntfs/frequencies
  • tests/fixtures/gtfs2ntfs/minimal_with_config

ref: ND-963

@patochectp
Copy link
Member

patochectp commented Jul 27, 2020

One question remain, do we need to keep the following tests (which should now all be covered by this complete fixture):

* `test/fixtures/gtfs2ntfs/levels_and_pathways`

* `tests/fixtures/gtfs2ntfs/platforms`

* `tests/fixtures/gtfs2ntfs/frequencies`

* `tests/fixtures/gtfs2ntfs/minimal_with_config`

these tests can be removed

@woshilapin
Copy link
Contributor Author

these tests can be removed

Done in f88a103. However, I couldn't remove tests/fixtures/gtfs2ntfs/frequencies since these fixtures are also used in tests related to ODT. Maybe a future clean up could integrate ODT tests into the main GTFS test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants