Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove 'mutable-model' feature #883

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

woshilapin
Copy link
Contributor

@woshilapin woshilapin commented Jan 4, 2023

This feature, that was introduced for an experimentation, didn't prove itself safe and constrained enough. Let's remove it.

Original PR was #761.

For details, opening this door of mutability was opening an opportunity to make the Model inconsistent. The consequence of that would be disastrous, since relations in the graph might become incorrect, the information incoherent and raise subtle bugs that might be hard to debug and fix.

Another problem with this modification, we modify the Model after it has been sanitized. But creating new Calendar was added, possibly connected, but possibly not (because other API for connecting), which means the Model probably ends up with orphan Calendar that should be sanitized (even if connected, the one that has been replaced might have become an orphan).

@woshilapin woshilapin requested review from ArnaudOggy and a team January 4, 2023 16:30
@ArnaudOggy
Copy link
Contributor

@woshilapin Ok for me. Feel free to merge.

Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to remove it, I think a bit more sharing on why it was added (maybe just a link to first PR) and more interesting why it's not worth keeping it would be nice.

@woshilapin woshilapin merged commit 9f174c3 into master Jan 5, 2023
@woshilapin woshilapin deleted the remove-mutable-model branch January 5, 2023 09:06
@woshilapin
Copy link
Contributor Author

I improved a bit the description. But to be honest, I vaguely remember finding an example of using this API and breaking the Model but it was a long time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants