Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] NetexFR : change StopPlaceType for bus #891

Merged
merged 1 commit into from
Mar 27, 2023
Merged

[fix] NetexFR : change StopPlaceType for bus #891

merged 1 commit into from
Mar 27, 2023

Conversation

nlehuby
Copy link
Contributor

@nlehuby nlehuby commented Mar 27, 2023

about #888

@ArnaudOggy
Copy link
Contributor

There would surely be a way to make it more precise, on the busStation and onstreetBus segmentation,
but we are running out of time and we don't seem to have a maintenance contract for this converter 😢.
No problem to set onstreetBus by default.

woshilapin
woshilapin approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering what you explained in #888, this seems reasonable.

@ArnaudOggy
Copy link
Contributor

@nlehuby
There will surely be impacts on the transport.data.gouv.fr side. Do you know if someone will test and validate? 🤔

@ArnaudOggy ArnaudOggy merged commit 22b5972 into hove-io:master Mar 27, 2023
@nlehuby nlehuby deleted the busstation branch March 27, 2023 14:50
@ArnaudOggy ArnaudOggy mentioned this pull request Mar 27, 2023
Merged
@ArnaudOggy ArnaudOggy changed the title NetexFR : change StopPlaceType for bus [fix] NetexFR : change StopPlaceType for bus Mar 27, 2023
@ArnaudOggy ArnaudOggy mentioned this pull request Mar 27, 2023
Closed
@fchabouis fchabouis mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datanel datanel datanel approved these changes

@woshilapin woshilapin woshilapin approved these changes

@ArnaudOggy ArnaudOggy ArnaudOggy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nlehuby @ArnaudOggy @datanel @woshilapin