[tech] Fix opening/closing times on frequency lines #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudOggy
force-pushed
the
fix_frequency_line_opening
branch
from
60afde7
to
3e4762e
Compare
ArnaudOggy
force-pushed
the
fix_frequency_line_opening
branch
from
8228bb0
to
3d598e0
Compare
woshilapin
previously approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Covered by tests, looks good to me. Here is some propositions, maybe not everything should be used, not sure of the maintenability of some of what I propose.
src/model.rs
Outdated
Comment on lines
644
to
648
| if let Some(vj_idx) = c.vehicle_journeys.get_idx(&frequency.vehicle_journey_id) | ||
| { | ||
| return Some((vj_idx, frequency)); | ||
| } | ||
| None |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
src/model.rs
Outdated
Comment on lines
652
to
659
| c.vehicle_journeys[vj_idx] | ||
| .stop_times | ||
| .first() | ||
| .map(|st| st.departure_time), | ||
| c.vehicle_journeys[vj_idx] | ||
| .stop_times | ||
| .last() | ||
| .map(|st| st.arrival_time), |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
woshilapin
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.