Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Display for CommentType #942

Merged
merged 1 commit into from
Mar 7, 2024
Merged

impl Display for CommentType #942

merged 1 commit into from
Mar 7, 2024

Conversation

datanel
Copy link
Member

@datanel datanel commented Mar 7, 2024

No description provided.

@datanel datanel requested a review from patochectp March 7, 2024 10:40
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe strum can be used? Only for one use, it would probably be too much, but there might be more of these to replace 🤷

@datanel datanel changed the base branch from master to clippy/chrono March 7, 2024 14:50
@datanel
Copy link
Member Author

datanel commented Mar 7, 2024

Maybe strum can be used? Only for one use, it would probably be too much, but there might be more of these to replace 🤷

That's what I saw too but it thought it was overkill

patochectp
patochectp previously approved these changes Mar 7, 2024
Base automatically changed from clippy/chrono to master March 7, 2024 16:09
@datanel datanel dismissed patochectp’s stale review March 7, 2024 16:09

The base branch was changed.

@datanel datanel merged commit e7bbf0a into master Mar 7, 2024
13 checks passed
@datanel datanel deleted the comment_type/display branch March 7, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants