some performance improvements

pybb/models.py

@@ -131,16 +131,13 @@ def get_absolute_url(self):
     def posts(self):
         return Post.objects.filter(topic__forum=self).select_related()
 
-    def get_last_post(self):
+    @property
+    def last_post(self):
         try:
             return self.posts.order_by('-created')[0]
         except IndexError:
             return None
 
-    @property
-    def last_post(self):
-        return self.get_last_post()
-
     def get_parents(self):
         """
         Used in templates for breadcrumb building
@@ -194,12 +191,11 @@ def head(self):
             return None
         return self._head[0]
 
-    def get_last_post(self):
-        return self.posts.order_by('-created').select_related('user')[0]
-
     @property
     def last_post(self):
-        return self.get_last_post()
+        if not getattr(self, '_last_post', None):
+            self._last_post = self.posts.order_by('-created').select_related('user')[0]
+        return self._last_post
 
     def get_absolute_url(self):
         return reverse('pybb:topic', kwargs={'pk': self.id})

pybb/templates/pybb/user.html

@@ -22,7 +22,7 @@ <h1>{{ target_user }}</h1>
             <div>
                 <a href="{% url 'pybb:user_posts' target_user.get_username %}">
                     {% trans "Number of posts" %}:
-                    {{ target_user.posts.all.count }}
+                    {{ target_profile.post_count }}
                 </a>
             </div>
             <div>{% trans "Date of registration" %}: {% pybb_time target_user.date_joined %}</div>

pybb/templates/pybb/users.html

@@ -15,7 +15,7 @@ <h1>{% trans "Users" %}</h1>
         {% for profile in page.object_list %}
             <li class="user">
                 <span class="author">{{ profile }}</span>
-                <span class="post_count">{{ profile.posts.count }}</span>
+                <span class="post_count">{{ profile.post_count }}</span>
                 <span class="updated">{{ profile.date_joined|date:"d M Y" }}</span>
             </li>
         {% endfor %}

pybb/views.py

@@ -185,6 +185,8 @@ def get_queryset(self):
         self.topic.views += 1
         self.topic.save()
         qs = self.topic.posts.all().select_related('user')
+        if defaults.PYBB_PROFILE_RELATED_NAME:
+            qs = qs.select_related('user__%s' % defaults.PYBB_PROFILE_RELATED_NAME)
         if not perms.may_moderate_topic(self.request.user, self.topic):
             qs = perms.filter_posts(self.request.user, qs)
         return qs