Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No finish event, end event called when it shouldn't be. #112

Closed
SeanHayes opened this issue Nov 30, 2016 · 1 comment
Closed

No finish event, end event called when it shouldn't be. #112

SeanHayes opened this issue Nov 30, 2016 · 1 comment

Comments

@SeanHayes
Copy link
Contributor

I noticed a discrepancy between my handlers running in a live env and running during tests. In test using a mock response the end event gets called, but it doesn't get called in production. The node docs say that the end event should only get called when the stream is in flowing mode: https://nodejs.org/api/stream.html#stream_event_end

Conversely, in a live env the finish event gets fired on my responses, but not on mock responses.

@eugef
Copy link
Owner

eugef commented Feb 9, 2018

finish event is fired with the latest version of package

@eugef eugef closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants