Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate detection of C++17 features like std::chrono::floor #81

Closed
ja11sop opened this issue Sep 10, 2016 · 1 comment
Closed

Consolidate detection of C++17 features like std::chrono::floor #81

ja11sop opened this issue Sep 10, 2016 · 1 comment

Comments

@ja11sop
Copy link

ja11sop commented Sep 10, 2016

Commit 59d9cfa breaks gcc 6+ and clang 3.8+ when --std=c++1z is set because the _cplusplus macro is defined as 201500 and 201406 respectively. In other words not whatever value it will be to indicate C++17 support. That libc++ (I haven't checked) might already offer some of those features should be detected for separately, so the work-arounds in date.h are still provided for gcc and clang that build against libstdc++. (running Linux).

@HowardHinnant
Copy link
Owner

Thanks! Please reopen this issue if this is not addressed by 845ce25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants