Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charset/iconv/iconv.go need //#include <errno.h> #3

Closed
GoogleCodeExporter opened this issue Mar 8, 2016 · 4 comments
Closed

charset/iconv/iconv.go need //#include <errno.h> #3

GoogleCodeExporter opened this issue Mar 8, 2016 · 4 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
 On Mac OS X, hg clone, cd charset/iconv, make -k

What is the expected output? What do you see instead?
make -k 
CGOPKGPATH=go-charset.googlecode.com/hg/charset cgo --  iconv.go 
error: 'EILSEQ' undeclared (first use in this function)
error: (Each undeclared identifier is reported only once
error: 'EINVAL' undeclared (first use in this function)
error: 'E2BIG' undeclared (first use in this function)
unresolved names
make: *** [_obj/_cgo_run] Error 2
make: Target `all' not remade because of errors.

What version of the product are you using? On what operating system?


Please provide any additional information below.

Add the following line to iconv/iconv.go will fix the problem:

//#include <errno.h>


Original issue reported on code.google.com by Yi.Wang.2005 on 13 Aug 2011 at 2:30

@GoogleCodeExporter
Copy link
Author

BTW, need to change os.ErrorString into os.NewString on L132 of iconv.go to 
make it gomakable.

Original comment by Yi.Wang.2005 on 13 Aug 2011 at 2:33

@GoogleCodeExporter
Copy link
Author

what version of Mac OS? (it works for me on 10.6.6)
i will include errno.h anyway.

Original comment by rogpeppe@gmail.com on 13 Aug 2011 at 2:53

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

I am using 10.7 with XCode 4.1.

Original comment by Yi.Wang.2005 on 13 Aug 2011 at 3:01

@GoogleCodeExporter
Copy link
Author

Original comment by rogpeppe@gmail.com on 30 Mar 2012 at 7:20

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant