Auto expand fails in other languages than English

[Lucki]

The current implementation fails to find any expandable nodes if the language isn't English:

LemmyTools/lemmyTools.js

Line 471 in 111f1b8

clickableImages = document.querySelectorAll('[aria-label="Expand here"]');

E.g. German needs:

- clickableImages = document.querySelectorAll('[aria-label="Expand here"]'); 
+ clickableImages = document.querySelectorAll('[aria-label="hier erweitern"]');

However, this seems like a really fragile way to do this.

[Lucki]

I've seen you comments under the various keyboard navigation scripts and those have the same problem:

- const buttonText = event.code === nextPageKey ? "Next" : "Prev";
+ const buttonText = event.code === nextPageKey ? "Weiter" : "Zurück";

Comments are even worse with the singular state.

        case openCommentsKey:
            if (event.shiftKey) {
+                 try {
                    window.open(
-                     currentEntry.querySelector("a.btn[title$='Comments']").href,
+                         currentEntry.querySelector("a.btn[title$='Kommentar']").href,
                    );
+                 } catch (error) {
+                     window.open(
+                         currentEntry.querySelector("a.btn[title$='Kommentare']").href,
+                     );
+                 }
            } else {
+                 try {
-                     currentEntry.querySelector("a.btn[title$='Comments']").href,
+                     currentEntry.querySelector("a.btn[title$='Kommentar']").click();
+                 } catch (error) {
+                     currentEntry.querySelector("a.btn[title$='Kommentare']").click();
+                 }
            }
            break;

There has to be a better way.

[howdy-tsc]

Thank you for the reports and thank you for chiming in. Right now, Manipulating the DOM objects are limited and we are using what is being given to us with lemmy-ui. Im an amateur and doing this with my limited know how and learning a lot! If anyone has a better idea than me please help out. I admittedly made the function quickly with what seemed obvious. Perhaps there is something I am overlooking to make this work without the literally query all selector being required for functionality like this.

We are doing a code clean up right now which will give me some time to pause and revaluate some functions as the script is going to look vastly different on 0.2

Thank you.

[howdy-tsc]

@csm10495 implemented a fix that looks for the classname versus the language dynamic text of the expand link. Should fix it.Thank you @csm10495!!! It's in as of 0.2.0.1