Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependency on botbuilder-dialogs to cut out 300MB of transitive dependencies. #1882

Closed
SirensOfTitan opened this issue Dec 20, 2019 · 2 comments
Milestone

Comments

@SirensOfTitan
Copy link

Are you sure this is an issue with the Botkit core module?

Yes, it's explicitly about a dependency that botkit has on botbuilder-dialogs.

What are you trying to achieve or the steps to reproduce?

Right now, using the botkit or botbuilder-adapter-slack in our application balloons our docker image size by over 300MB due to a botbuilder-dialogs dependency on cldr-data.

botbuilder-dialogs has been patched to just import the couple json files necessary from cldr-data over the full payload here:
microsoft/botbuilder-js#1444

... and this fix was released as 4.7.0. It would be very worthwhile to upgrade this dependency, as it'll reduce transitive disk costs significantly.

What was the result you received?

botkit still depends on botbuilder-dialogs version 4.6.0, leading to 300MB of unnecessary i18n JSON data being imported into our app.

What did you expect?

botkit upgrades its dependency on botbuilder-dialogs (and other botbuilder packages) to 4.7.0.

@benbrown benbrown added this to the 4.6.+ milestone Dec 20, 2019
@benbrown
Copy link
Contributor

Agreed! Will do so in the next upcoming release.

@benbrown
Copy link
Contributor

addressed in 4.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants