Added define's for CAN message ID's + increased specialization of enu… #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made 4 changes in my repo:
val
andval_item
by moving where a space is. It wasn't parsing my values because it was expecting a space after eachval_item
, which the last item won't have. I've moved it to expect a space before each item.#define
's for the CAN ID's of the messagesConsidering the following value list - there's two signals called
state
, but for different message ID's (1 and 2):Generated enum definition before change (won't compile):
![image](https://user-images.githubusercontent.com/7203144/218007129-39b0eae7-60f9-4cc5-86b8-435b2bbeee8c.png)
After (now generated after corresponding message definition):
![image](https://user-images.githubusercontent.com/7203144/218006695-ad8ce7c3-e6d2-408d-94f1-5ef00dc89b5a.png)
(After, but without the
-N
flag to remove the message ID's)Q:
I'm unsure what effect my proposed changes have to the global
VAL_TABLE_
section in a dbc file. I suspect they won't get generated after these changes, because I'm only generating enums for vals that are associated with a message.