Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

multiple data races in map access #29

Closed
fsouza opened this issue Feb 6, 2013 · 4 comments
Closed

multiple data races in map access #29

fsouza opened this issue Feb 6, 2013 · 4 comments

Comments

@fsouza
Copy link
Contributor

fsouza commented Feb 6, 2013

To reproduce this, run tests with the -race flag. I didn't paste it here because there are more than 50 races (about 4200 lines), but here comes a gist: https://gist.github.com/fsouza/4722172.
fsouza pushed a commit to tsuru/config that referenced this issue Feb 6, 2013
config: added ReadAndWatchFile function
f2f261d 
This function will update configuration whenever a file changes.

This change introduces many data races (actually, it inherits these data
races from howeyc/fsnotify). This issue has been reported as
howeyc/fsnotify#29.

Closes #2.
@fsouza fsouza mentioned this issue Feb 6, 2013
Merged
@howeyc
Copy link
Owner

howeyc commented Feb 7, 2013

Thanks for working on fixing the races on BSD.

@howeyc
Copy link
Owner

howeyc commented Feb 7, 2013

Is the -race flag only on tip or something? I couldn't get that on 1.0.3.

@fsouza
Copy link
Contributor Author

fsouza commented Feb 7, 2013

Yes, @howeyc. It will be included in go 1.1 release. Currently it's available only at tip. I will prepare another pull request for Linux. Unfortunately, I don't access to any Windows machine, so I won't be able to test it on Windows.

@fsouza
Copy link
Contributor Author

fsouza commented Feb 7, 2013

Oh, sorry. Looks like you already did some work on Linux and Windows. Thanks! :-)

@fsouza fsouza closed this as completed Feb 7, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fsouza @howeyc