Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Event Processing Pipeline (WIP) #65
This introduces a pipeline for processing events before forwarding them to the Event channel.
Initially I avoided changing the exported API, but since I began adding additional pipeline steps, I've started to implement changes as originally proposed in #64.
The tests pass on OS X, Linux, BSD and Windows and I have been testing it from Looper as well. I have seen some intermittent failures in
Looks good to me.
I think my big challenge for the recursive watcher will be ensuring all the options for the pipeline steps are available to all the folders.
I'd really like to tease apart the code for fsnotify and the inotify/kqueue/etc. adapters, but I'd rather do a big internal refactoring as a separate pull request.
Sorry this has been taking me so long. I'm going to try to get recursive watching wrapped up
If anyone else wants to try out this code from a branch, just add a remote for
Obviously it's going to take a bit longer to complete... with the number of unchecked boxes and my current pace.
It would be great to have some others try out the code and API changes on a branch before this gets merged to master. /cc @robfig
minux suggested a user-defined function to replace Pattern and Hidden. It's essentially a
What about adding multiple filters? These filters are slightly different than the Event pipeline:
Also, heard the suggestion of making the Event interface smaller.