Make sure CallKit session is ended on fail

[Pagebakers]

This fixes an issue where the CallKit session isn't ended when making an outbound call fails. Keeping the green topbar active when exiting the app.

[fabriziomoscon]

Thanks a lot!
I am experiencing this issue as well. I will test and merge as soon as possible

[SimonRobinson]

@Pagebakers @fabriziomoscon probably need to remove the same if statement from callDidDisconnect fn as well. For me if the caller hangs up first the callKit session is also not ended as when disconnect fires call.state is not connected.

(void)callDidDisconnect:(TVOCall *)call
...
 if (self.call.state == TVOCallStateConnected) {
    [self performEndCallActionWithUUID:call.uuid];
 }

Should be just?

  [self performEndCallActionWithUUID:call.uuid];

[fabriziomoscon]

I see.
I made these two changes in this commit:
4349162
because the calls were not disconnected correctly.
So rather than remove the conditions all together I think we need to find the best way to disconnect all possible status of calls without leaving a zombie call in the background and without having errors in the log.
I will definitely test further the two scenarios you mentioned, but also it would be great if you can see and test what happens when you remove the commit I referred to

[SimonRobinson]

@fabriziomoscon ok got it, will have a test and let you know.

[oshimayoan]

Any progress on this?

[fabriziomoscon]

I haven't had time to test it yet.

[fabriziomoscon]

@SimonRobinson in the scenario you are describing is the iOS app making or receiving the call?

[fabriziomoscon]

@Pagebakers only today I could test your change and confirm that it is necessary. Well done and well spotted! My personal apologies for the delay to merge this change

[fabriziomoscon]

published on npm 2.11.1

[fabriziomoscon]

@SimonRobinson you are right!
I added 4349162 to placate errors in the log, but as you pointed out the condition prevent a correct call disconnection in case the callee hangs the call up.

I have opened a separate issue to track this error in the log.
I will remove now the condition mentioned and published a new npm version.

Many thanks for your patience!

[fabriziomoscon]

the fix mentioned above has been published on npm 2.11.2

[Pagebakers]

Great, thanks for merging this in!

[SimonRobinson]

@fabriziomoscon thanks for fixing and merging. FYI was testing with receiving calls.