Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Image in notification #91

Closed
clari7744 opened this issue May 21, 2023 · 1 comment 路 Fixed by #94
Closed

Cover Image in notification #91

clari7744 opened this issue May 21, 2023 · 1 comment 路 Fixed by #94

Comments

@clari7744
Copy link

Hello, I'm not entirely sure how to format this request, and I'd PR it myself if I could figure out C 馃槄
But would it be possible to use the cover metadata as the notification icon?
Example of Notification
Just a small thing, but would make it look nice :)

@hoyon
Copy link
Owner

hoyon commented May 22, 2023

Heya, mpv-mpris does use album art data if it's provided as an external file with one of these names, but not with embedded album art.

Afaik mpv doesn't expose any way of getting the album art from their API so the only way it would work is for us to extract the image data ourselves. This isn't something I'm likely to work on but PRs welcome if anyone is keen!

gnojus added a commit to gnojus/mpv-mpris that referenced this issue Aug 19, 2023
This adds a dependency on libavformat to extract the cover art.

Fixes hoyon#91
@hoyon hoyon closed this as completed in #94 Aug 30, 2023
hoyon pushed a commit that referenced this issue Aug 30, 2023
This adds a dependency on libavformat to extract the cover art.

Fixes #91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants