Makefile: Allow to append CFLAGS / LDFLAGS from environment. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the CFLAGS / LDFLAGS specified in the Makefile were appended, which prevented e.g. CFLAGS="-O3" from becoming effective. see e.g. https://bugs.gentoo.org/887795 for a related downstream issue.
olifre
referenced
this pull request
Dec 27, 2022
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Apr 4, 2023
https://build.opensuse.org/request/show/1077054 by user mia + dimstar_suse - Update to 1.0 * rename album fields to match MusicBrainz internal names gh#hoyon/mpv-mpris#81 * Fix string leaks in property change handler gh#hoyon/mpv-mpris#84 * Makefile: Allow to append CFLAGS / LDFLAGS from environment. gh#hoyon/mpv-mpris#87 * Do not use the default GMainContext gh#hoyon/mpv-mpris#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
CFLAGS/LDFLAGSspecified in the Makefile were appended, which prevented e.g.CFLAGS="-O3"from becoming effective.see e.g. https://bugs.gentoo.org/887795 for a related downstream issue.