Allowing large messages #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when sending a large message after a short one, the pointer of the FrameBuffer would be stuck to the end of the short message, with all the parts of the large message overwriting each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I was testing to send some megabytes of data. In server_socketserver.py:74 8192 bytes are read at a time. The FrameBuffer then tries to extract a frame, fails, but doesn't reset the _buffers position to the end, so that the next incoming data is appended, instead of overwriting the first 8192 bytes of the message (or parts thereof).
I just discovered coilmq today, cool project, thx for it. I am not familiar with it, so the above is just a first guess, just m2c.