Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to skip tests that require sudo #403

Closed
pagrubel opened this issue Apr 3, 2019 · 2 comments
Closed

Allow user to skip tests that require sudo #403

pagrubel opened this issue Apr 3, 2019 · 2 comments
Assignees
@reidpr
Labels
enhancement
Milestone
0.9.10

Comments

@pagrubel
Copy link
Contributor

pagrubel commented Apr 3, 2019

Check for a flag such as CH_HAVE_SUDO before performing tests that need sudo
@j-ogas
Copy link
Contributor

j-ogas commented Apr 9, 2019

We have a similar skipping mechanism for docker, e.g., CH_TEST_SKIP_DOCKER=yes. Perhaps we could include CH_TEST_SKIP_SUDO=yes to common.bash.

@reidpr reidpr added this to the next milestone Apr 15, 2019
@reidpr
Copy link
Collaborator

reidpr commented Apr 15, 2019

Right now we just test for access to the sudo command in common.bash. I think the right approach is just extend that test to only set the variable if it's unset and document it. It's already named for external access.

@reidpr reidpr self-assigned this Apr 22, 2019
@reidpr reidpr mentioned this issue Apr 22, 2019
Merged
@reidpr reidpr closed this as completed in b912d55 Apr 23, 2019
@reidpr reidpr modified the milestones: next, 0.9.10 Apr 23, 2019
@alazzaro alazzaro mentioned this issue Jul 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reidpr reidpr

Labels
enhancement
Projects
None yet
Milestone
0.9.10
Development

No branches or pull requests
3 participants
@reidpr @pagrubel @j-ogas