Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genericize ch-docker2squash #465

Closed
reidpr opened this issue Jun 27, 2019 · 2 comments
Closed

genericize ch-docker2squash #465

reidpr opened this issue Jun 27, 2019 · 2 comments
Assignees
@shanegoff
Labels
enhancement
Milestone
0.12

Comments

@reidpr
Copy link
Collaborator

reidpr commented Jun 27, 2019

When the unprivileged builder PRs are merged, that will make Docker-specific scripts obsolete. I believe ch-docker2squash is the only one left.
@reidpr reidpr added this to the next milestone Jun 27, 2019
@shanegoff
Copy link
Contributor

Are we renaming ch-docker2tar to ch-builder2tar in #460?
Should I open a branch, or make commits to #460?

@reidpr
Copy link
Collaborator Author

reidpr commented Jun 27, 2019

Are we renaming ch-docker2tar to ch-builder2tar in #460?

PR #455 will land first, but yes.

Should I open a branch, or make commits to #460?

Wait until PR #455 lands, then make a new PR.

@shanegoff shanegoff mentioned this issue Sep 10, 2019
Merged
@reidpr reidpr modified the milestones: next, 0.12 Sep 17, 2019
@reidpr reidpr closed this as completed in 078b3f4 Sep 17, 2019
j-ogas pushed a commit that referenced this issue Nov 1, 2019
@shanegoff @j-ogas
PR #532 from @Brofessional: docker2squash -> builder2squash (closes #465
1d1b7f3 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanegoff shanegoff

Labels
enhancement
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
2 participants
@reidpr @shanegoff