ch-pull2dir: tidy use of sed #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing to kick Travis? Will re-open. |
|
Thanks. Yeah I took a look at the failing tests but they didn't seem related. |
reidpr
changed the title
j-ogas
pushed a commit
that referenced
this pull request
Aug 14, 2020
j-ogas
pushed a commit
that referenced
this pull request
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor change I wanted to propose to the
ch-pull2dirscript after I ran into this issue this past weekend using it. With image names containing multiple/characters (e.g. from GitLab container registries) they hadn't been replaced with thesedcommand. Additionally, these will be observed by thermused to remove the original tarball.