Skip to content

Commit

Permalink
mfu: remove newly adde sync calls in flist_copy until we know they ar…
Browse files Browse the repository at this point in the history
…e needed since they slow things down
  • Loading branch information
adammoody committed Sep 24, 2018
1 parent c88788e commit 76e06e1
Showing 1 changed file with 5 additions and 11 deletions.
16 changes: 5 additions & 11 deletions src/common/mfu_flist_copy.c
Expand Up @@ -498,10 +498,6 @@ static int mfu_copy_set_metadata(int levels, int minlevel, mfu_flist* lists,
MPI_Barrier(MPI_COMM_WORLD);
}

/* force metadata changes to backend */
sync();
MPI_Barrier(MPI_COMM_WORLD);

return rc;
}

Expand Down Expand Up @@ -640,7 +636,6 @@ static int mfu_create_directories(int levels, int minlevel, mfu_flist* lists,

/* wait for all procs to finish before we start
* creating directories at next level */
sync();
MPI_Barrier(MPI_COMM_WORLD);

/* stop our timer */
Expand Down Expand Up @@ -918,7 +913,6 @@ static int mfu_create_files(int levels, int minlevel, mfu_flist* lists,
}

/* force inode info to disk before starting to copy data */
sync();
MPI_Barrier(MPI_COMM_WORLD);

return rc;
Expand Down Expand Up @@ -1468,11 +1462,6 @@ static int mfu_copy_files(mfu_flist list, uint64_t chunk_size,
/* free the list of file chunks */
mfu_file_chunk_list_free(&head);

/* force data to backend to avoid the following metadata
* setting mismatch, which may happen on lustre */
sync();
MPI_Barrier(MPI_COMM_WORLD);

return rc;
}

Expand Down Expand Up @@ -1653,6 +1642,11 @@ int mfu_flist_copy(mfu_flist src_cp_list, int numpaths,
rc = -1;
}

/* force data to backend to avoid the following metadata
* setting mismatch, which may happen on lustre */
sync();
MPI_Barrier(MPI_COMM_WORLD);

/* set permissions, ownership, and timestamps if needed */
mfu_copy_set_metadata(levels, minlevel, lists, numpaths,
paths, destpath, mfu_copy_opts);
Expand Down

0 comments on commit 76e06e1

Please sign in to comment.