Mss 0001 #290
Merged
Mss 0001 #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskisner
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
Overall looks good. Note that the trivial whitespace changes in C++ code are due to a version upgrade of the uncrustify tool. Some default spacing option changed between 0.66 and 0.68, but we confirmed that the changes in this branch are made with the newer version, so fine to merge that update.
examples/templates/ground.in
Outdated
| @@ -122,6 +122,9 @@ export TOAST_NUM_THREADS=${OMP_NUM_THREADS} | |||
| echo "OpenMP # threads: ${OMP_NUM_THREADS}" | |||
| echo "TOAST # threads: ${TOAST_NUM_THREADS}" | |||
|
|
|||
| export NUMBA_THREADING_LAYER=tbb | |||
| export NUMBA_NUM_THREADS=${OMP_NUM_THREADS} | |||
|
|
|||
There was a problem hiding this comment.
These numba things are no longer needed. They are set automatically on the first import of the toast module:
https://github.com/hpc4cmb/toast/blob/master/src/toast/mpi.py#L40
| @@ -955,6 +991,68 @@ def write_common_flags(self, local_start=0, flags=None, **kwargs): | |||
| self._put_common_flags(local_start, flags, **kwargs) | |||
| return | |||
|
|
|||
| @function_timer | |||
| def read_hwp_angle(self, local_start=0, n=0, **kwargs): | |||
| """Read half-wave plate angle | |||
There was a problem hiding this comment.
Thanks for moving the HWP motion into the TOD class where it belongs.
|
Merging after @tskisner fixed the Travis test setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes arising from the mss-0001 simulation effort.