Consistent use of Units in detector data, pixel data, and noise models #593
Conversation
tskisner
force-pushed
the
toast3_units
branch
2 times, most recently
from
846239c
to
11dc02e
Compare
tskisner
force-pushed
the
toast3_units
branch
from
7233eb1
to
ada94af
Compare
|
Ok, this will need rebased after #592 is merged, since there will be conflicts, but this work now includes:
Also, this does not solve the slow convergence of the gain template in the case of a "perfect" time domain model. We can work on that in the next PR. |
* Enforce consistent units throughout the detector, pixel, and noise classes. * Use units when doing map-domain I/O. * Introduce a new Unit trait type for operators and templates, and support this trait type throughout the configuration system. * Maintain units in the noise model classes, including for detector inverse variance weights. * Check units when assigning to DetectorData objects. * Propagate units when duplicating and redistributing Observations. * Do not copy internal interval containing all samples when redistributing observations. * Scale detector data when doing arithmetic with the Combine operator * Replace old collective debug logging with `Logger.debug_rank()` * Run format_source.sh
tskisner
force-pushed
the
toast3_units
branch
from
ada94af
to
afa4f10
Compare
…age to catch those.
* Fix support for container parsing from CLI. * Expand unit test coverage. * Change PixelsWCS bounds to a flat container, not nested.
…creating or remapping data.
Work in progress on supporting consistent units between detector data, pixel data, etc.