Update required language standard to C++14 #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our bundled copy of the google test framework now requires C++14. We could relax this in the future if needed once we reorganize the compiled extension and ensure that all features are tested from the python interface. In that scenario, we could then completely remove the compiled test runner and gtest.
|
Actually, this was not a problem with the language standard. The bundled gtest is the last release that still supports C++11. The issue was that an external (newer) gtest was installed in my testing conda environment, and the headers from that were being picked up instead of the bundled headers. So if anything, it is a problem with our header search order. Closing this now and will either revisit in the future or remove gtest altogether. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our bundled copy of the google test framework now requires C++14. We could relax this in the future if needed once we reorganize the compiled extension and ensure that all features are tested from the python interface. In that scenario, we could then completely remove the compiled test runner and gtest.