Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: FreqCacheEmbeddingBag._weight.ProcessGroup is initialized before _weight initialized #1434

Closed
zxgx opened this issue Aug 11, 2022 · 1 comment
Closed

[BUG]: FreqCacheEmbeddingBag._weight.ProcessGroup is initialized before _weight initialized #1434

zxgx opened this issue Aug 11, 2022 · 1 comment
Assignees
@feifeibear
Labels
bug Something isn't working

Comments

@zxgx
Copy link
Contributor

zxgx commented Aug 11, 2022

馃悰 Describe the bug

When I init a DLRM with ParallelFreqAwareEmbeddingBag, the bug is reported as the following:
image

I believe that is because the ParallelFreqAwareEmbeddingBag init its _weight.ProcessGroup before the _weight is initialized.

After I swap above line with its next line, the traceback shows another error:
image

It looks like some api update issue.

Environment

No response
@zxgx zxgx added the bug Something isn't working label Aug 11, 2022
@feifeibear feifeibear self-assigned this Aug 11, 2022
@feifeibear
Copy link
Contributor

Thanks for the feedback. I will have a look.

feifeibear added a commit that referenced this issue Aug 11, 2022
@feifeibear
hotfix #1434 (#1437)
c9427a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feifeibear feifeibear

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feifeibear @zxgx