Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training model save problem #2746

Closed
xcxhy opened this issue Feb 16, 2023 · 10 comments · Fixed by #2846
Closed

Training model save problem #2746

xcxhy opened this issue Feb 16, 2023 · 10 comments · Fixed by #2846
Labels
enhancement New feature or request

Comments

@xcxhy
Copy link

xcxhy commented Feb 16, 2023

Describe the feature

Hello, I use the ChatGPT/examples/train_dummpy.py to train GPT2, and the training is successful, but the trained model cannot be found. Can you write a document to explain the problems of saving the model and using the training model?

@xcxhy xcxhy added the enhancement New feature or request label Feb 16, 2023
@terminator123
Copy link

i met the same problem too

@ht-zhou
Copy link
Contributor

ht-zhou commented Feb 16, 2023

Thanks for your feedback, but I have to remind you that train_dummy.py using random input, and you may not find any improvement after training.
Anyway, we'll add some guidance and demo to help save and inference the model.

@HuggingLLM
Copy link

@ht-zhou I have read source code, maybe train_prompts.py also not save the checkpoint. please add more demo help us to run it.

@xcxhy
Copy link
Author

xcxhy commented Feb 16, 2023

@NLP-ZY Agree. I notice is that neither train_dumm.py nor train_prompts.py save the checkpoint.

@YeHaijia
Copy link

same

1 similar comment
@lajiyuan
Copy link

same

@Syno8
Copy link

Syno8 commented Feb 19, 2023

I mkdir first as follows and save the model correctly.
os.makedirs(os.path.dirname(args.save_path), exist_ok=True)

@A-biao96
Copy link

i met the same problem too

Hello, did you solve the problem?

@FrankLeeeee
Copy link
Contributor

This issue shall be fixed in #2846 once it is merged.

@A-biao96
Copy link

i met the same problem too

Hello, did you solve the problem?
This issue shall be fixed in #2846 once it is merged.

Thanks, I got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants