[p2p]add object list send/recv #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit df7e650.
FrankLeeeee
reviewed
May 25, 2022
FrankLeeeee
reviewed
May 25, 2022
colossalai/communication/p2p.py
Outdated
Comment on lines
180
to
182
| for tensor_send in object_send_next: | ||
| send_next_op = dist.P2POp(dist.isend, tensor_send, next_rank) | ||
| ops.append(send_next_op) |
There was a problem hiding this comment.
Torch has this API torch.distributed.broadcast_object_list, not sure how the performance is like compared to a list of P2P Op.
There was a problem hiding this comment.
The API broadcast_object_list sends the data to all ranks in group. I think this pr is something like send/recv_object_list.
There was a problem hiding this comment.
One way to do this is to create a process group for each pair of adjacent stages, and broadcast from one rank to the other rank in this process group.
FrankLeeeee
reviewed
May 25, 2022
feifeibear
reviewed
May 25, 2022
FrankLeeeee
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.