[tensor] refactor chunk mgr and impl MemStatsCollectorV2 #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feifeibear
reviewed
Jun 7, 2022
| @@ -236,10 +235,9 @@ def access_chunk(self, tensor: torch.Tensor) -> None: | |||
| self.accessed_chunks.add(chunk) | |||
| self.total_mem[chunk.device_type] += chunk.mem | |||
|
|
|||
| def release_chunk(self, tensor: torch.Tensor) -> None: | |||
| def release_chunk(self, chunk: Chunk) -> None: | |||
There was a problem hiding this comment.
will the API changing affects our old code?
There was a problem hiding this comment.
I update all relevant code.
There was a problem hiding this comment.
You'd better update the version.txt in this PR. And post a new release.
There was a problem hiding this comment.
Chunk manager's methods should not be called by users directly. I think user's code won't be influenced by this PR.
| def get_chunks(self, tensors: Iterable[torch.Tensor]) -> FrozenSet[Chunk]: | ||
| return frozenset([self.get_chunk(tensor) for tensor in tensors]) | ||
|
|
||
| def add_extern_static_tensor(self, tensor: torch.Tensor) -> None: |
There was a problem hiding this comment.
I think you need to make sure the static tensor is not registered as a chunk managed tensor later.
feifeibear
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor chunk mgr for easily monitoring memory usage.