[engine] fixed empty op hook check #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feifeibear
approved these changes
Jun 10, 2022
FrankLeeeee
force-pushed
the
hotfix/engine-hook
branch
from
a5143e1
to
b45c853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1095 . The bug in the issue is because that empty hooks are registered on the modules and these hooks seem to incur extra memory, perhaps there are some underlying tensor cloning. With this PR, this bug can be fixed. Some experiment results are shown below.
Model: ResNet101
Dataset: CIFAR10 (resize to 224)
Optim: Adam
Batch size: 128
#GPU: 1