[tensor] refactor param op hook #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some documentation for better readability and maintainability? |
DONE |
feifeibear
reviewed
Jun 13, 2022
| Example:: | ||
| >>> with ParamOpHookManager.use_hooks(*hooks): | ||
| >>> do_something() | ||
| >>> with ParamOpHookManager.use_hooks(): |
There was a problem hiding this comment.
why nest ParamOpHookManager context?
There was a problem hiding this comment.
In case some users want to nest. In most cases, we don't need to nest.
There was a problem hiding this comment.
I think users should not know what is OpHook. It is not a common-sense concept. Why do they need to have a manager?
There was a problem hiding this comment.
They can extend profiler by this manager. E.g. before op sample sth, after op sample sth. Indeed, it's for advanced developers.
feifeibear
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch.autograd.Functionensures the device of original inputs and grads are the same. Since zero hook may change the device of input in pre fwd, we execute pre fwd out ofautograd.Function.