[hotfix] fix zero init ctx numel #1128
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wesley-Jzy
reviewed
Jun 16, 2022
| @@ -169,11 +172,18 @@ def _post_context_exec(self): | |||
| torch.set_rng_state(self.cpu_rng_state) | |||
| torch.cuda.set_rng_state(self.cuda_rng_state) | |||
|
|
|||
| params = frozenset(self.top_module.parameters()) | |||
There was a problem hiding this comment.
Because Module's parameters() function uses set() to store result, I think it will not return duplicated param?
There was a problem hiding this comment.
Yes, but for "in" operation, set is much faster than list.
Wesley-Jzy
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.