Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] fix param op hook #1131

Merged
merged 3 commits into from
Jun 17, 2022
Merged

[hotfix] fix param op hook #1131

merged 3 commits into from
Jun 17, 2022

Conversation

ver217
Copy link
Member

@ver217 ver217 commented Jun 17, 2022 •
edited

torch.autograd.Function will convert all return tensors of forward() to torch.Tensor. For ColoTensor and ColoParameter, spec will be lost. We have to store the specifications and reconstruct ColoTensor/ColoParameter after applying torch.autograd.Function.

ZeRO + TP is also supported.

@ver217 ver217 requested a review from feifeibear June 17, 2022 05:36
@ver217 ver217 merged commit 789cad3 into hpcaitech:main Jun 17, 2022
@ver217 ver217 deleted the hotfix/colo-parameter branch June 17, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feifeibear feifeibear feifeibear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ver217 @feifeibear