[zero] added error message to handle on-the-fly import of torch Module class #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feifeibear
reviewed
Jun 20, 2022
colossalai/utils/model/utils.py
Outdated
| @@ -80,6 +80,10 @@ def __exit__(self, exc_type, exc_value, traceback): | |||
| torch.set_default_dtype(self._old_default_dtype) | |||
|
|
|||
| def _disable_class(cls): | |||
| if not hasattr(cls, '_old_init'): | |||
| raise AttributeError( | |||
| f"_old_init is not found in the {cls.__name__}, please make sure that you have this class imported before entering the context." | |||
There was a problem hiding this comment.
make sure import InsertPostInitMethodToModuleSubClasses?
There was a problem hiding this comment.
make sure cls is imported
There was a problem hiding this comment.
I can make it clearer
feifeibear
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zero init context has a precondition that the module class has to be imported before entering the context. However, sometimes this is not always so. For example:
This example will raise exception because BertModel is only imported on the fly. This PR adds an error message for easier debugging.