[checkpoint] save sharded optimizer states #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto tensor/test_model
feifeibear
commented
Jul 8, 2022
| # only rank 0 saves the REPLICATE tensors. | ||
| optim_state = { | ||
| 'epoch': epoch, | ||
| 'optimizer': colo_state_dict(optimizer, state_dict_func=torch.optim.Optimizer.state_dict), |
There was a problem hiding this comment.
现在Optimizer state_dict里面的Tensor可能是shard之后的colotensor。
如果直接序列化，会有process_group无法序列化的问题。
我想参考你写colo_state_dict解决这个事情。
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok, 我觉得ok。但是那个函数不知道被谁被更新过了，有一些不明确的参数命名, e.g. mapping1, mapping2，可以顺手改一下。
|
Previsouly, ColoTensor has dist.ProcessGorup type attributes. Therefore, it is impossible to _save a ColoTensor when call state_dict(). |
ZhaoYi1222
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.