[fx] modify the calculation of node_size in MetaInfoProp for activation checkpointing usages #1425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this change won't affect usage of node.meta['tensor_meta'], but I have adopted the expressions in https://github.com/pytorch/pytorch/blob/f9533560ccb2d789bc78caa360d021f72f5ebc7b/torch/fx/passes/graph_manipulation.py#L82 so as to compute the memory consumptions for activation and model parameters separately. This will make it easy for us to retrieve the activation memory cost directly and correctly.