Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fx] fixed adapative pooling size concatenation error #1489

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

FrankLeeeee
Copy link
Contributor

Fixed the shape concatenation error in adapative pooling. This allows the torchvision ResNet to be traced successfully with meta args.

A sample test script is given below:

import torch
import torchvision.models as tm
from colossalai.fx import ColoTracer

torch_model = tm.resnet152()
input = torch.rand(32, 3, 224, 224, device="meta")
tracer = ColoTracer()
graph = tracer.trace(torch_model, meta_args={"x": input})

@Cypher30 Cypher30 self-requested a review August 24, 2022 07:41
Copy link
Contributor

@Cypher30 Cypher30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@FrankLeeeee FrankLeeeee merged commit 3da68d6 into hpcaitech:main Aug 25, 2022
@FrankLeeeee FrankLeeeee deleted the hotfix/avgpool-patch branch January 26, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants