New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fx] provide an accurate estimation of memory. #1587
Merged
FrankLeeeee
merged 18 commits into
hpcaitech:main
from
super-dainiu:feature/better_flop_tensor
Sep 14, 2022
Merged
[fx] provide an accurate estimation of memory. #1587
FrankLeeeee
merged 18 commits into
hpcaitech:main
from
super-dainiu:feature/better_flop_tensor
Sep 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/better_flop_tensor
super-dainiu
requested review from
Cypher30,
FrankLeeeee and
YuliangLiu0306
September 12, 2022 14:44
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
Good work. There are some overall comments below:
|
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
super-dainiu
changed the title
[fx] provide an accurate estimation of memory except for GPT-2.
[fx] provide an accurate estimation of memory.
Sep 13, 2022
FrankLeeeee
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
After hacking the autograd graph and the save_tensors_hook, I managed to compute the accurate memory estimation of
torchvision.models
. We can compare the result with #1547.Test