[autoparallel] added new linear module handler #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,6 +90,20 @@ class TrainCycleItem: | |||
| total: Any | |||
|
|
|||
|
|
|||
| class CommunicationType(Enum): | |||
There was a problem hiding this comment.
I think we could unify all the communication related operation to CommSpec, which could give communication cost information using get_comm_cost api, and support runtime application with convert_spec_to_action. The resharding costs is estimated by ShapeConsistencyManager which uses CommSpec internally.
FrankLeeeee
force-pushed
the
feature/auto-parallel
branch
from
ed4b522
to
fcd82e4
Compare
YuliangLiu0306
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new version of linear module handler by inheriting the new node handler and the new data structures for sharding strategy. The various strategy generators are to be implemented in the next PR.