[autoparallel] Add pofo sequence annotation #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ColossalAI
Daily merge
FrankLeeeee
reviewed
Sep 23, 2022
| @@ -157,7 +157,7 @@ def _find_offload_regions(nodes: List[Node]): | |||
| current_region = None | |||
|
|
|||
| for idx, node in enumerate(nodes): | |||
| if hasattr(node, 'activation_offload') and isinstance(getattr(node, 'activation_offload', False), tuple): | |||
| if hasattr(node, 'activation_offload') and isinstance(getattr(node, 'activation_offload', False), list): | |||
There was a problem hiding this comment.
isinstance(getattr(node, 'activation_offload', False), list) seems weird to me, it seems that getattr will return a boolean value, but it is checking isinstance for the type list.
There was a problem hiding this comment.
Yes the default should be None.
BTW, I change this from tuple to list to simplify the annotation.
FrankLeeeee
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
Previously I add pofo solver in #1608, and in this PR I finish annotate graph module with pofo sequence, with the help of PR #1618 , finishing the complete pipeline of pofo solver.
The following is a brief summary of our rotor/pofo solver pipeline:
MetaInfoProptool by @super-dainiu to get all the meta information in the graph.linearizemodule.later I will plot some results here.