[autoparallel] added compute resharding costs for node handler #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # by the current node handler | ||
| for prev_sharding_spec in prev_sharding_specs: | ||
| fwd_cost = shape_consistency_manager.shape_consistency(prev_sharding_spec, current_sharding_spec) | ||
| bwd_cost = shape_consistency_manager.shape_consistency(current_sharding_spec, prev_sharding_spec) |
There was a problem hiding this comment.
ShapeConsistencyManager will distinguish the mission type(training or inference) by a forward_only label, and returns a option related cost. Therefore, we don't have to compute fwd cost and bwd cost separately here.
There was a problem hiding this comment.
I see. I notice that ShapeConsistencyManager only returns a total cost. How to get the fwd and bwd cost then?
There was a problem hiding this comment.
I mean I want to store this cost as a TrainCycleItem so that solver can choose whether to consider the bwd cost.
YuliangLiu0306
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added the method
update_resharding_costto node handler and the node handler can support generating the sharding while registering sharding strategies. This PR cannot be tested at this moment, I have added aTODOnote to add it back when other handlers are finished.