New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fx] Add concrete info prop #1677
Merged
Cypher30
merged 44 commits into
hpcaitech:main
from
Cypher30:feature/add_concrete_info_prop
Oct 4, 2022
Merged
[fx] Add concrete info prop #1677
Cypher30
merged 44 commits into
hpcaitech:main
from
Cypher30:feature/add_concrete_info_prop
Oct 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ColossalAI
Daily merge
Cypher30
commented
Oct 3, 2022
|
||
|
||
def _profile_concrete(target: Callable, *args, **kwargs) -> Tuple[Tuple[Any, ...], GraphInfo]: | ||
""" | ||
Profile a Callable function with args and kwargs on concrete devices. | ||
"""Profile a Callable function with args and kwargs on concrete devices by https://github.com/Cypher30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the shortcut for you guys to check what I'm doing!!
…ColossalAI into feature/add_concrete_info_prop
super-dainiu
reviewed
Oct 3, 2022
super-dainiu
reviewed
Oct 3, 2022
super-dainiu
reviewed
Oct 4, 2022
super-dainiu
approved these changes
Oct 4, 2022
Cypher30
commented
Oct 4, 2022
# find the grad for parameter in args and kwargs | ||
param_size = 0 | ||
|
||
def get_param_size(x): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this part is for retrieving param size in args and kwargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
In this PR, I provide
ConcreteInfoProp
to facilitate the meta info estimation, we also provide the time profiler that track the running time of each node. You could check the docstring of function_profile_concrete
for more information.For example, now you could run
and get the following results