Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autoparallel] where_handler_v2 #1688

Merged
merged 3 commits into from Oct 13, 2022
Merged

[autoparallel] where_handler_v2 #1688

merged 3 commits into from Oct 13, 2022

Conversation

YuliangLiu0306
Copy link
Contributor

What does PR do?

  1. simply, this PR add where_handler using refactored APIs.
  2. In this PR, I overload post_process and register_strategy function to recover the logical strategy into physical strategy. The cost model rule is:
  • using logical shape in compute_cost, memory_cost, and communication_cost computaion.
  • using physical shape in resharding_cost computation.
    Note: This rule may miscalculate some costs due to different kernel implement method, but it works fine for most of cases.

@FrankLeeeee
Copy link
Contributor

This PR has a conflict to be resolved.

@YuliangLiu0306 YuliangLiu0306 merged commit 319d654 into hpcaitech:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankLeeeee FrankLeeeee FrankLeeeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YuliangLiu0306 @FrankLeeeee