[feat] add flash attention #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
feifeibear
reviewed
Oct 26, 2022
feifeibear
reviewed
Oct 26, 2022
| @triton.jit | ||
| def _fwd_kernel( | ||
| Q, K, V, sm_scale, | ||
| TMP, L, M, # NOTE: TMP is a scratchpad buffer to workaround a compiler bug |
There was a problem hiding this comment.
can you add type hints for each parameter?
for example
TMP : torch.Tensor, L : int
There was a problem hiding this comment.
Not sure about some param. Will update it with alphafold version flash attention
feifeibear
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add cuda and triton flash attention